Skip to content

Commit b5b9e27

Browse files
committed
xo wasn't seeing deps
1 parent 1130d2e commit b5b9e27

File tree

12 files changed

+34
-11355
lines changed

12 files changed

+34
-11355
lines changed

gulpfile.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ const htmlminConfig = {
4242

4343
const imageConfig = {
4444
pngquant: true,
45+
svgo: false,
4546
concurrent: 10,
4647
jpegoptim: true
4748
};

package.json

Lines changed: 13 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,9 @@
77
"node": "7"
88
},
99
"scripts": {
10-
"test": "xo",
10+
"test": "./node_modules/.bin/xo",
1111
"build": "./node_modules/.bin/gulp build",
12-
"watch": "./node_modules/.bin/gulp watch",
13-
"precommit": "yarn test",
14-
"prepush": "yarn test"
12+
"watch": "./node_modules/.bin/gulp watch"
1513
},
1614
"browserslist": [
1715
"> 1%",
@@ -39,40 +37,21 @@
3937
},
4038
"author": "Jakob Anderson",
4139
"license": "MIT",
42-
"lint-staged": {
43-
"src/*": []
44-
},
4540
"dependencies": {
46-
"autoprefixer": "^6.7.7",
47-
"ava": "^0.18.2",
48-
"babel-core": "^6.24.0",
49-
"babel-preset-es2015": "^6.24.1",
50-
"babelify": "^7.3.0",
51-
"cssnano": "^3.10.0",
52-
"gulp": "^3.9.1",
53-
"gulp-htmlmin": "^3.0.0",
54-
"gulp-postcss": "^6.4.0",
55-
"gulp-sourcemaps": "^2.5.1",
56-
"gulp-uglify": "^2.1.2",
57-
"gulp-util": "^3.0.8",
58-
"localforage": "^1.5.0",
59-
"rollup-stream": "^1.19.0",
60-
"static-eval": "^1.1.1",
61-
"uglifyify": "^3.0.4",
62-
"vinyl-buffer": "^1.0.0",
63-
"vinyl-source-stream": "^1.1.0",
64-
"xo": "^0.18.1"
41+
"chai": "^3.5.0",
42+
"localforage": "^1.5.0"
6543
},
6644
"devDependencies": {
6745
"autoprefixer": "^6.7.7",
46+
"ava": "^0.18.2",
47+
"babel-core": "^6.24.0",
6848
"babel-preset-env": "^1.4.0",
49+
"babel-preset-es2015": "^6.24.1",
6950
"babel-preset-es2017": "^6.24.1",
7051
"babel-preset-latest": "^6.24.1",
7152
"babelify": "^7.3.0",
7253
"browserify": "^14.3.0",
73-
"chai": "^3.5.0",
7454
"cssnano": "^3.10.0",
75-
"gulp": "^3.9.1",
7655
"gulp-htmlmin": "^3.0.0",
7756
"gulp-image": "^2.8.0",
7857
"gulp-livereload": "^3.8.1",
@@ -81,11 +60,16 @@
8160
"gulp-sourcemaps": "^2.6.0",
8261
"gulp-svgo": "^1.0.3",
8362
"gulp-uglify": "^2.1.2",
63+
"gulp-util": "^3.0.8",
64+
"gulp": "^3.9.1",
8465
"husky": "^0.13.3",
8566
"lint-staged": "^3.4.0",
67+
"rollup-stream": "^1.19.0",
8668
"sw-precache": "^5.1.1",
69+
"uglifyify": "^3.0.4",
8770
"vinyl-buffer": "^1.0.0",
8871
"vinyl-source-stream": "^1.1.0",
89-
"watchify": "^3.9.0"
72+
"watchify": "^3.9.0",
73+
"xo": "^0.18.2"
9074
}
9175
}

public/dist/img/social-banner.png

28.2 KB
Loading

public/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<!DOCTYPE html><html lang="en"><head><title>Practice JavaScript</title><meta charset="UTF-8"><meta name="viewport" content="width=device-width,initial-scale=1"><meta name="theme-color" content="#0C141F"><link rel="manifest" href="/manifest.json"><link rel="icon" href="/launch-icon.svg"></head><body><style>body{opacity:0;transition:opacity .2s ease-in-out}</style><heading class="site-heading"><div class="container"><span><img class="logo" src="./dist/img/monitor.svg" alt="Logo" height="80px"><h1>Practice JavaScript!</h1></span><nav class="controls"><div><img id="prev-problem" class="prev-problem" src="./dist/img/back.svg" alt="Previous problem" title="Previous problem (CMD + SHIFT + RETURN or CTRL + SHIFT + ENTER)" height="80"><div class="title">Back</div></div><div><img id="shuffle-problems" class="shuffle-problems" src="./dist/img/shuffle.svg" alt="Shuffle problems" title="Shuffle problems" height="80"><div class="title">Shuffle</div></div><div><img id="next-problem" class="next-problem" src="./dist/img/next.svg" alt="Next problem" title="Next problem (CMD + RETURN or CTRL + ENTER)" height="80"><div class="title">Next</div></div></nav></div></heading><div class="container"><main><div class="problem-group"><div id="problem" class="problem">&zwnj;</div></div><div id="answer" class="answer"><!--TODO: add ability to peek answer, while giving up any points for the question.--></div><div class="code-and-tests"><div id="test-area" class="test-area"><div id="test-total" class="test-total"></div><div id="test-suite" class="test-suite"></div><div id="assert-console" class="assert-console console monospace"><h4>TEST ERRORS</h4><div id="assert-output"></div></div></div><div class="code-and-eval-console"><label for="code" class="visually-hidden">Code Editor</label><textarea id="code" class="code monospace" rows="10" autofocus autocomplete="off" autocorrect="off" autocapitalize="off" spellcheck="false"></textarea><div id="eval-console" class="eval-console console monospace"><h4>CODE OUTPUT</h4><div id="eval-output"></div></div></div></div></main></div><!-- practice-javascript-bottom-banner --><div class="ads-bottom"><ins class="adsbygoogle" style="display:inline-block;width:728px;height:90px" data-ad-client="ca-pub-4039212144643368" data-ad-slot="9721927778"></ins></div><footer><div class="copyright">© 2017 <a href="https://twitter.com/jakob_anderson">Jakob Anderson</a></div><div class="issues"><a href="https://github.com/PracticeJavaScript/practicejavascript.com/issues">Problems? Leave an issue on github</a></div><div class="icon-license">Icons designed by <a href="http://www.flaticon.com/authors/gregor-cresnar">Gregor Cresnar</a> from Flaticon</div></footer><link href="./dist/css/style.css" rel="stylesheet"><script src="./dist/js/bundle.min.js"></script><script src="./dist/js/loadJS.js"></script><script src="./dist/js/sw-registration.js"></script><!-- DEFER AND ASYNC ALL THE OTHER GARBAGE THAT ISN'T MY APP --><script>"practicejavascript.com"===window.location.host&&window.addEventListener("load",function(){loadJS("//www.google-analytics.com/analytics.js",function(){ga("create","UA-97392792-1","auto"),ga("send","pageview")}),loadJS("//pagead2.googlesyndication.com/pagead/js/adsbygoogle.js",function(){(adsbygoogle=window.adsbygoogle||[]).push({})})})</script></body></html>
1+
<!DOCTYPE html><html lang="en"><head><meta charset="UTF-8"><title>Practice JavaScript</title><meta name="viewport" content="width=device-width,initial-scale=1"><meta name="theme-color" content="#0C141F"><link rel="manifest" href="/manifest.json"><link rel="icon" href="/launch-icon.svg"><!-- OPEN GRAPH STUFF --><meta property="og:title" content="Practice JavaScript!"><meta property="og:description" content="Practice JavaScript with this fun game"><meta property="og:type" content="website"><meta property="og:image" content="https://practicejavascript.com/dist/img/social-banner.png"><meta property="og:url" content="https://practicejavascript.com"><!-- TWITTER CARDS STUFF --><meta name="twitter:card" content="summary"><meta name="twitter:site" content="@jakob_anderson"><meta name="twitter:title" content="Practice JavaScript!"><meta name="twitter:description" content="Practice JavaScript with this fun game"><meta name="twitter:image" content="https://practicejavascript.com/dist/img/social-banner.png"><meta name="twitter:image:alt" content="PracticeJavaScript Logo"></head><body><style>body{opacity:0;transition:opacity .2s ease-in-out}</style><heading class="site-heading"><div class="container"><span><img class="logo" src="./dist/img/monitor.svg" alt="Logo" height="80px"><h1>Practice JavaScript!</h1></span><nav class="controls"><div><img id="prev-problem" class="prev-problem" src="./dist/img/back.svg" alt="Previous problem" title="Previous problem (CMD + SHIFT + RETURN or CTRL + SHIFT + ENTER)" height="80"><div class="title">Back</div></div><div><img id="shuffle-problems" class="shuffle-problems" src="./dist/img/shuffle.svg" alt="Shuffle problems" title="Shuffle problems" height="80"><div class="title">Shuffle</div></div><div><img id="next-problem" class="next-problem" src="./dist/img/next.svg" alt="Next problem" title="Next problem (CMD + RETURN or CTRL + ENTER)" height="80"><div class="title">Next</div></div></nav></div></heading><div class="container"><main><div class="problem-group"><div id="problem" class="problem">&zwnj;</div></div><div id="answer" class="answer"><!--TODO: add ability to peek answer, while giving up any points for the question.--></div><div class="code-and-tests"><div id="test-area" class="test-area"><div id="test-total" class="test-total"></div><div id="test-suite" class="test-suite"></div><div id="assert-console" class="assert-console console monospace"><h4>TEST ERRORS</h4><div id="assert-output"></div></div></div><div class="code-and-eval-console"><label for="code" class="visually-hidden">Code Editor</label><textarea id="code" class="code monospace" rows="10" autofocus autocomplete="off" autocorrect="off" autocapitalize="off" spellcheck="false"></textarea><div id="eval-console" class="eval-console console monospace"><h4>CODE OUTPUT</h4><div id="eval-output"></div></div></div></div></main></div><!-- practice-javascript-bottom-banner --><div class="ads-bottom"><ins class="adsbygoogle" style="display:inline-block;width:728px;height:90px" data-ad-client="ca-pub-4039212144643368" data-ad-slot="9721927778"></ins></div><footer><div class="copyright">© 2017 <a href="https://twitter.com/jakob_anderson">Jakob Anderson</a></div><div class="issues"><a href="https://github.com/PracticeJavaScript/practicejavascript.com/issues">Problems? Leave an issue on github</a></div><div class="icon-license">Icons designed by <a href="http://www.flaticon.com/authors/gregor-cresnar">Gregor Cresnar</a> from Flaticon</div></footer><link href="./dist/css/style.css" rel="stylesheet"><script src="./dist/js/bundle.min.js"></script><script src="./dist/js/loadJS.js"></script><script src="./dist/js/sw-registration.js"></script><!-- DEFER AND ASYNC ALL THE OTHER GARBAGE THAT ISN'T MY APP --><script>"practicejavascript.com"===window.location.host&&window.addEventListener("load",function(){loadJS("//www.google-analytics.com/analytics.js",function(){ga("create","UA-97392792-1","auto"),ga("send","pageview")}),loadJS("//pagead2.googlesyndication.com/pagead/js/adsbygoogle.js",function(){(adsbygoogle=window.adsbygoogle||[]).push({})})})</script></body></html>

public/manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"name": "Practice JavaScript with this fun game",
44
"background_color": "#0C141F",
55
"theme_color": "#0C141F",
6-
"display": "standalone",
6+
"display": "minimal-ui",
77
"icons": [
88
{
99
"src": "launcher-icon.svg",

public/service-worker.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)