Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem in integrating isort with pre-commit #1832

Closed
ghost opened this issue Oct 26, 2021 · 4 comments
Closed

Problem in integrating isort with pre-commit #1832

ghost opened this issue Oct 26, 2021 · 4 comments

Comments

@ghost
Copy link

ghost commented Oct 26, 2021

Isort returns failure every time Pre-Commit runs.

Screenshot from 2021-10-26 04-29-02
Screenshot from 2021-10-26 04-29-15
Screenshot from 2021-10-26 04-29-19
Screenshot from 2021-10-26 04-29-22
Screenshot from 2021-10-26 04-29-25
Screenshot from 2021-10-26 04-29-40
Screenshot from 2021-10-26 04-30-02
Screenshot from 2021-10-26 04-30-16

@pzelnip
Copy link
Contributor

pzelnip commented Oct 27, 2021

What if you change the isort config in .pre-commit.yaml to:

-   repo: https://github.com/pycqa/isort
    rev: 5.9.3
    hooks:
      - id: isort
        name: isort
        always_run: true
        args: ["--check-only"]

Does that fix the issue?

@ghost
Copy link
Author

ghost commented Oct 29, 2021

No. If I do this this error appears.

Screenshot from 2021-10-29 00-06-06
Screenshot from 2021-10-29 00-06-23

In order not to get this error, I opted to use the entry option, but when I do that I get the other error.

@ghost
Copy link
Author

ghost commented Oct 30, 2021

Hi! I got tired of trying to use pre-commit. I'm going back to the Makefile. Sorry for the inconvenience.

@ghost ghost closed this as completed Oct 30, 2021
@Corfucinas
Copy link

This error is happening to me as well on #1890

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants