Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema cleanup items #146

Open
4 of 6 tasks
fedorov opened this issue Nov 17, 2016 · 2 comments
Open
4 of 6 tasks

Schema cleanup items #146

fedorov opened this issue Nov 17, 2016 · 2 comments
Assignees
@fedorov @che85

Comments

@fedorov
Copy link
Member

fedorov commented Nov 17, 2016 •
edited by che85
Loading

Let's keep adding small things to this issue that should be fixed after RSNA ...

  • review attribute types and add DICOM VRs as needed
  • revisit JSON-LD and link with documentation (to be populated)
  • LabelID -> labelID
  • fix capitalization code* -> Code* in the context files
  • add schema for context files
  • check consistency of *CodeSequence - it is inconsistent in seg schema and parametric maps at least
fedorov added a commit to fedorov/dcmqi that referenced this issue Nov 18, 2016
@fedorov
BUG: make capitalization consistent with the converters parameters
c5dc85d 
see QIICR/QuantitativeReporting#85 (comment) and QIICR#146
@fedorov fedorov mentioned this issue Nov 18, 2016
Merged
@fedorov
Copy link
Member Author

fedorov commented Jan 18, 2017

Also related to this, I started working on the schema for segmentation context related items.

@fedorov fedorov modified the milestone: 1.0 release Jan 18, 2017
@fedorov fedorov mentioned this issue Jan 18, 2017
Merged
che85 added a commit to che85/dcmqi that referenced this issue Jan 20, 2017
@che85
ENH: consistency of *CodeSequence (issue QIICR#146)
9b05026
che85 added a commit to che85/dcmqi that referenced this issue Jan 20, 2017
@che85
ENH: renamed LabelID to labelID (issue QIICR#146)
f165d71
@che85 che85 mentioned this issue Jan 20, 2017
Merged
che85 added a commit to che85/dcmqi that referenced this issue Jan 20, 2017
@che85
ENH: consistency of *CodeSequence (issue QIICR#146)
2c5df4e
che85 added a commit to che85/dcmqi that referenced this issue Jan 20, 2017
@che85
ENH: renamed LabelID to labelID (issue QIICR#146)
23fc509
@che85 che85 mentioned this issue Jan 24, 2017
Closed
@fedorov
Copy link
Member Author

fedorov commented Feb 1, 2017

The remaining issues are bigger and need to be reconsidered as part of the revision of the schema organization and harmonization with the standard. This will be done after the 1.0.0 release.

@fedorov fedorov removed this from the 1.0 release milestone Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedorov fedorov

@che85 che85

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fedorov @che85