-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐞]Vite Import for q-astro-manifest.json failing #207
Comments
This should work in a node environment already, which is why I don't seem to understand the issue. Also we don't want node being the only thing that can run in Qwik Astro's server runtime. It would work in this case, but not be ideal in the integration. Do you have a minimal reproduction link I can look at? |
re:node statement: That's fair, I was certain this is what would have been said, but did want to try and throw some solution at it. Absolutely I didn't realise the CLI had changed since logging the issue Netlify Deployment: https://eclectic-dango-67483d.netlify.app/ Sorry for the spam looking link, default netlify link. |
Is the issue in both the project and netlify deploy? Or only a specific place? |
The issue is in both versions. Literally I haven't touched the projects in any way. Replication steps: |
I followed the steps here and was unable to reproduce, making me think there's something specific to your environment affecting this 🤔 |
See "internal server error" in screenshot above. Can you try to deploy to Vercel / Netlify? But that could be me doing something wrong either. Vercel link |
I'll take a look here soon 😄 . And just checking, you have an environment variable that sets vercel's node version to 22? One thing we could do, is do a node readFile and then have a setting in the integration to use a dynamic json import instead when that doesn't work. So: error. then error says: Are you using node? If not, please do |
Hey @Shane-Donlon! Let me know if the latest version fixed your issue. |
Edit 2 SSG Works in both Netlify and Vercel SSR Fails in both Netlify and Vercel. Vercel errors are better so showing this one. SSG Repo: SSG Link: SSR Repo: SSR link: |
Just to come back on this, https://vercel.com/docs/functions/runtimes/node-js/node-js-versions#default-and-available-versions |
You should see an error in the server logs. What was the error? |
I'm on my phone so forgive the formatting Error in renderToStaticMarkup function of @qwikdev/astro: Error: @qwikdev/astro: Failed to read the q-astro-manifest.json file. This file is required for the @qwikdev/astro integration to work. It seems like you're using node. If this is not the case, please set the isNode option to false in the integration options in astro.config.mjs. Also make sure this is the case with both your local and deployed environment. at Object.renderToStaticMarkup (file:///var/task/dist/server/chunks/server_COsjBHlt.mjs:4736:13) at process.processTicksAndRejections (node:internal/process/task_queues:105:5) at async renderFrameworkComponent (file:///var/task/dist/server/chunks/astro/server_bR_VmPe9.mjs:1969:26) at async renderComponent (file:///var/task/dist/server/chunks/astro/server_bR_VmPe9.mjs:2122:10) at async renderChild (file:///var/task/dist/server/chunks/astro/server_bR_VmPe9.mjs:1285:13) 17:12:51.536 There was an uncaught error in the middle of the stream while rendering /. Error: @qwikdev/astro: Failed to read the q-astro-manifest.json file. This file is required for the @qwikdev/astro integration to work. It seems like you're using node. If this is not the case, please set the isNode option to false in the integration options in astro.config.mjs. Also make sure this is the case with both your local and deployed environment. at Object.renderToStaticMarkup (file:///var/task/dist/server/chunks/server_COsjBHlt.mjs:4736:13) at process.processTicksAndRejections (node:internal/process/task_queues:105:5) at async renderFrameworkComponent (file:///var/task/dist/server/chunks/astro/server_bR_VmPe9.mjs:1969:26) at async renderComponent (file:///var/task/dist/server/chunks/astro/server_bR_VmPe9.mjs:2122:10) at async renderChild (file:///var/task/dist/server/chunks/astro/server_bR_VmPe9.mjs:1285:13) |
Could be that when Vercel or Netlify make their own directory for their serverless functions the q-astro-manifest path is lost 🤔 Will have a version for you to try soon |
Try |
Thanks! You might need to wrap the isNode (what you added yesterday) with ' if isDev && isNode' for local Dev server. |
I was never able to reproduce in dev. I do have a reproduction of the issue in vercel here. Looks like we still have the issue. Making another link for verbose logging. |
Try this one |
Yeah it seems vercel is moving it to the wrong location:
|
I know you're still messing around with things,
Updated dependencies "dependencies": {
"@astrojs/check": "^0.9.4",
"@builder.io/qwik": "^1.12",
"@qwikdev/astro": "https://pkg.pr.new/QwikDev/astro/@qwikdev/astro@331fa9b",
"astro": "^5.1"
}, npm install |
Ok just tested and this looks to be fixed on Let me know if that's not the case and I can re-open or create a new issue |
Yeah seems to be fixed. This is what I tested. SSG in Dev SSG in Production (Netflify) |
Which component is affected?
Build process
Describe the bug
Getting the below error on starting dev server.
https://github.com/QwikDev/astro/blob/main/libs/qwikdev-astro/server.ts#L76
Full error
Reproduction
this cannot be blank
Steps to reproduce
npm create @qwikdev/astro@latest
Create a project
npm run start / npm run dev
System Info
Additional Information
Hey Jack 👋
I was looking into this and was thinking of migrating the import to Node, this seems to work for me locally, and I can do a local build.
Example code:
https://github.com/QwikDev/astro/blob/main/libs/qwikdev-astro/server.ts#L76
Let me know if you want a PR etc..
Just trying to start contributing with code as well as issues.
Happy new year 🥳
The text was updated successfully, but these errors were encountered: