Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Compression for proof output files via gz compression stream api #268

Open
James-Oswald opened this issue Nov 28, 2023 · 1 comment
Open

Add Compression for proof output files via gz compression stream api #268

James-Oswald opened this issue Nov 28, 2023 · 1 comment
Labels
API-Break Will break test results or backwards compatibility. Leftmost number in semantic versioning Enhancement New feature good first issue Good for newcomers
Milestone
PMH 2.0.0

Comments

@James-Oswald
Copy link
Member

James-Oswald commented Nov 28, 2023 •
edited
Loading

Files are BIG, make them small. Use .json.gz file extension.

https://developer.mozilla.org/en-US/docs/Web/API/Compression_Streams_API
@James-Oswald James-Oswald added Enhancement New feature optional This feature is not required to be implemented by the current implementation team labels Nov 28, 2023
@James-Oswald James-Oswald removed the optional This feature is not required to be implemented by the current implementation team label Dec 9, 2023
@RyanR712
Copy link
Collaborator

RyanR712 commented Dec 16, 2023 •
edited
Loading

In addition to this, as discussed on 12/15, tracking only the changes made to a JSON from step to step may compress file sizes further. The .gzip solution seems easiest however

Diff solution mentioned in #317 just now

@James-Oswald James-Oswald changed the title Add Compression for proof output files Add Standard Compression for proof output files Dec 16, 2023
@James-Oswald James-Oswald changed the title Add Standard Compression for proof output files Add Compression for proof output files via gz compression stream api Dec 16, 2023
@James-Oswald James-Oswald added this to the PMH 2.0.0 milestone Dec 16, 2023
@James-Oswald James-Oswald added the good first issue Good for newcomers label Dec 16, 2023
@James-Oswald James-Oswald mentioned this issue Dec 16, 2023
Open
2 tasks
@RyanR712 RyanR712 added the API-Break Will break test results or backwards compatibility. Leftmost number in semantic versioning label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API-Break Will break test results or backwards compatibility. Leftmost number in semantic versioning Enhancement New feature good first issue Good for newcomers
Projects
None yet
Milestone
PMH 2.0.0
Development

No branches or pull requests
2 participants
@James-Oswald @RyanR712