Code style and comment fixes

Signed-off-by: Michael Weimann <[email protected]>
RAJAKONA · Feb 10, 2019 · 587a140 · 587a140
1 parent 6c52821
commit 587a140
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/lib/private/Settings/Personal/PersonalInfo.php b/lib/private/Settings/Personal/PersonalInfo.php
@@ -65,8 +65,10 @@ class PersonalInfo implements ISettings {
 	 * @param IUserManager $userManager
 	 * @param IGroupManager $groupManager
 	 * @param AccountManager $accountManager
+	 * @param IAppManager $appManager
 	 * @param IFactory $l10nFactory
 	 * @param IL10N $l
+	 * @param EncryptionManager $encryptionManager
 	 */
 	public function __construct(
 		IConfig $config,
@@ -151,7 +153,7 @@ public function getForm() {
 	 *
 	 * @return array
 	 */
-	private function getWhereIsYourDataParams() {
+	private function getWhereIsYourDataParams(): array {
 
 		$adminContactConfigId = $this->config->getSystemValue(ServerInfo::SETTING_PROVIDER_ADMIN_CONTACT);
 		$adminContact = $this->userManager->get($adminContactConfigId);

diff --git a/lib/private/Settings/Theming/ServerInfo.php b/lib/private/Settings/Theming/ServerInfo.php
@@ -63,7 +63,7 @@ public function __construct(IConfig $config, IGroupManager $groupManager) {
 	/**
 	 * @return TemplateResponse
 	 */
-	public function getForm() {
+	public function getForm(): TemplateResponse {
 		$parameters = [
 			'location' => $this->config->getSystemValue(self::SETTING_LOCATION),
 			'provider' => $this->config->getSystemValue(self::SETTING_PROVIDER),
@@ -80,7 +80,7 @@ public function getForm() {
 	 *
 	 * @return array[] An array or arrays with the keys 'id' and 'displayName'
 	 */
-	private function getAdminListValues() {
+	private function getAdminListValues(): array {
 		$adminGroup = $this->groupManager->get('admin');
 		$users = $adminGroup->getUsers();
 
@@ -103,7 +103,7 @@ private function getAdminListValues() {
 	 *
 	 * @return string
 	 */
-	public function getSection() {
+	public function getSection(): string {
 		return 'theming';
 	}
 
@@ -114,7 +114,7 @@ public function getSection() {
 	 * the admin section. The forms are arranged in ascending order of the
 	 * priority values. It is required to return a value between 0 and 100.
 	 */
-	public function getPriority() {
+	public function getPriority(): int {
 		return 10;
 	}
 

diff --git a/settings/Controller/ServerInfoSettingsController.php b/settings/Controller/ServerInfoSettingsController.php
@@ -53,7 +53,7 @@ public function storeServerInfo(
 		string $providerWebsite,
 		string $providerPrivacyLink,
 		string $adminContact
-	) {
+	): void {
 		$configs = [
 			ServerInfo::SETTING_LOCATION => $location,
 			ServerInfo::SETTING_PROVIDER => $provider,