Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement Search in New Variables Page #315

Closed
RealRaven2000 opened this issue Aug 13, 2024 · 2 comments
Closed

Reimplement Search in New Variables Page #315

RealRaven2000 opened this issue Aug 13, 2024 · 2 comments

Comments

@RealRaven2000
Copy link
Owner

in the old settings dialog we could use the key F3 to repeat searching for a search term, now this doesn't work because the shortcut is highjacked by the built in search methods of content:

image

this "built in search method" is not able to se collapsed content and this fails discovering the desired information. Therefore it should be completely avoided while the variables page is shown.

We either need to come up with a different keyboard combo, or add a button for searching again. Since there is more space on screen in the new dialog the later method is probably the easiest.

@RealRaven2000 RealRaven2000 self-assigned this Aug 13, 2024
RealRaven2000 added a commit that referenced this issue Aug 17, 2024
RealRaven2000 added a commit that referenced this issue Aug 17, 2024
RealRaven2000 added a commit that referenced this issue Aug 29, 2024
@RealRaven2000 RealRaven2000 changed the title F3 to find search text again doesn't work in new variable page Reimplement Search in New Variables Page Aug 29, 2024
@RealRaven2000
Copy link
Owner Author

Lots of changes, here is the latest version to try out. The hardest part is selection focus, the window.find is very unpredictable depending on which button is clicked and where the user last clicked. This one recreates the find again feature with the buttons F4 and Shift+F4 (backwards):

smartTemplate-fx-4.8pre141.zip

I also added some (next/previous) buttons and improved readability. The find previous button doesn't currently work as reliable as pushing Shift+F4. If I cannot fix it this week I might remove it altogether.

image


To try the version above download zip file and drag the file into Thunderbird Add-ons Manager (do not extract contents, it won't install like that)

RealRaven2000 added a commit that referenced this issue Aug 29, 2024
RealRaven2000 added a commit that referenced this issue Aug 30, 2024
- eliminated window.find
- implemented my own search algorithm
@RealRaven2000 RealRaven2000 removed the bug label Aug 31, 2024
@RealRaven2000
Copy link
Owner Author

4.8 - published 03/09/2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant