Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of parameters in attach #1

Open
s00500 opened this issue Apr 16, 2018 · 3 comments
Open

Order of parameters in attach #1

s00500 opened this issue Apr 16, 2018 · 3 comments

Comments

@s00500
Copy link

s00500 commented Apr 16, 2018

This library changes the order of parameters in the attach() function as compared to the standard arduino library, please change this or document it!
Thanks

@JarekParal
Copy link
Member

Yes, that is my fault. I'm probably creating a new interface for the function attach() with two options:

  1. compatible with Arduino servo library - without parameter channel -> channel will be set automatically
  2. parameter channel change from int to enum class and then the standard function overloading will work

What do you think about this change?

@s00500
Copy link
Author

s00500 commented Apr 17, 2018

yes perfect, I was also thinking about having the channel as an optional attribute :-)

@JarekParal
Copy link
Member

Actually, I improve the documentation and in the future, I would like to refactor the library with cooperation to #2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants