-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could not build library with provided examples #26
Comments
Hi, I have the same problem, |
I've had the same issue so downgraded to 1.0.3 which works. |
Dear @JarekParal Thank you for your great library. |
yes, I would like to fix the bug in the coming month. I was very overloaded with a work until now, but it should be better now. Still, fix PR from anybody would be welcome. |
In case you would need/want to use the latest version (1.1.1), you can use it with PlatformIO IDE with Visual Studio Code. In [env:esp32dev]
platform = espressif32
board = esp32dev
framework = arduino
build_unflags = -std=gnu++11
build_flags = -std=gnu++17
lib_deps =
roboticsbrno/ServoESP32 @ 1.1.1 With this #include <Arduino.h>
#include <Servo.h>
static const int servoPin = 4;
Servo servo1;
void setup()
{
Serial.begin(115200);
servo1.attach(servoPin);
}
void loop()
{
for (int posDegrees = 0; posDegrees <= 180; posDegrees++)
{
servo1.write(posDegrees);
Serial.println(posDegrees);
delay(20);
}
for (int posDegrees = 180; posDegrees >= 0; posDegrees--)
{
servo1.write(posDegrees);
Serial.println(posDegrees);
delay(20);
}
} |
@Roemke (same ServoESP32 example as in the comment above) That is not a proper fix/solution, but at least it is a workaround. Please let me know if that would work for you. |
@JarekParal since it appears you don't use the official Arduino development software and thus won't be able to manually detect the introduction of changes that break the library for users of that software, I recommend you to set up an automated compilation of the library examples. This can be done by adding a GitHub Actions workflow to the repository. Arduino provides a GitHub Actions action specifically for this purpose, which is used in all the official Arduino repositories. Using that action in the workflow should make it quite easy to set up the system: |
Hi @per1234, thanks for your suggestion. A long time ago, we set up TravisCI which built the examples. But this is not working anymore and doesn't make sense to fix it. I have already tried to set up GitHub Actions for this repository a few months ago. But I was unable to get a workable version in the timeframe which I allocated to this task. Or any PR for this would be really welcome. For traceability, I created new issue #29. |
Hi @JarekParal I have this repository with working github actions build... If you allow me I can try to port this action to a PR in your repository, just let me know what you think about it. |
Hi @rsuzano, yes your help would be really appreciated. If you would be able to create working GitHub Action to compile the example files with Arduino IDE and/or with PlatformIO, then we should minimize the issues with builds and PR merges. When you will have something to share don't hesitate to open a PR. Thanks in advance. |
Thanks for this library. Replacing all occurrences of
platform.txt
|
This "fixed" library does compile however https://github.com/alunit3/ServoESP32/ |
Hi, I am trying to use this library on ESP32, but when I try to build the example I get more errors:
for example:
In file included from src/main.cpp:2: .pio/libdeps/esp32dev/ServoESP32/src/Servo.h:68:81: error: call to non-'constexpr' function 'const _Tp& std::min(const _Tp&, const _Tp&) [with _Tp = int]' static const int TIMER_RESOLUTION = std::min(16, SOC_LEDC_TIMER_BIT_WIDE_NUM);
Log, platformio.ini and code included.
Platform versions:
Espressif32 6.4.0
Atmel AVR 4.2.0
attachments.zip
The text was updated successfully, but these errors were encountered: