Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ROS1 native service servers don't report errors correctly #164

Closed
Carter12s opened this issue Jun 29, 2024 · 0 comments · Fixed by #169
Closed

New ROS1 native service servers don't report errors correctly #164

Carter12s opened this issue Jun 29, 2024 · 0 comments · Fixed by #169
Labels
bug Something isn't working ros1 For issues affecting the native ROS1 implementation

Comments

@Carter12s
Copy link
Collaborator

ROS Provides the ability for services to respond with a "false success byte following by a string" (encoded with normal length prefix) in the event of an error.

We should have the service server collect any errors that come from either internal issues or as reported by the User's service function and serialize them to an error message, and send that error message as the error response.

@Carter12s Carter12s added bug Something isn't working ros1 For issues affecting the native ROS1 implementation labels Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ros1 For issues affecting the native ROS1 implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant