Skip to content

Incorrect code snippet rendering in how-to-contribute-by-cpython-unittest.html #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tai271828 opened this issue Nov 27, 2021 · 6 comments

Comments

@tai271828
Copy link

The following code snippet is not rendered correctly. It should be some thing like this: USTPYTHONPATH=Lib cargo run --release ./Lib/test/test_unicode.py (double-dash and grey background)

Selection_550

I checked the markdown syntax with my Atom editor and it looks good. Maybe something else causes the rendering incorrectly.

@youknowone
Copy link
Member

Thank you for the report!

The referred document is: https://rustpython.github.io/blog/2020/04/04/how-to-contribute-by-cpython-unittest.html

@youknowone
Copy link
Member

For the document itself, I fixed it by fixing the document itself here: f962c17

@mireille-raad
Copy link
Member

Screen Shot 2021-12-01 at 1 42 46 PM

Does this work? should we close the issue?

@tai271828
Copy link
Author

In my opinion, this issue is resolved. Thanks for fixing and confirmation.

@mireille-raad
Copy link
Member

of course. Always create issues if you have ideas for content or general improvements.

@youknowone
Copy link
Member

The renderer bug itself is not fixed, but document bug is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants