Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Dead" link at section "split-method-instead-of-boolean-input-parameter" #344

Open
SABECK1 opened this issue Nov 28, 2023 · 3 comments
Open

Comments

@SABECK1
Copy link
Contributor

SABECK1 commented Nov 28, 2023

The link 1 at section split-method-instead-of-boolean-input-parameter is redirecting to a rather questionable website, that to me, has no relation to the styleguide at all.

I suppose it's for the best if the link would've been removed if the website isn't archived anywhere.

@SABECK1
Copy link
Contributor Author

SABECK1 commented Nov 28, 2023

Opened pull-request regarding this issue, removing the links in the German, Spanish, English and French version.
I would consider doing this in the other versions as well, if I could read them... Maybe I will try with Google Translate in the future.

@N2oB6n-SAP
Copy link
Member

Given that the other translations contain the same original links I simply updated them in #345 assuming that the URLs were in the right spot already. It does raise the question about our general policy regarding external links, though...

@N2oB6n-SAP
Copy link
Member

As for analysis of the root cause here: Most likely the original website (just checked silkand*.net) got hacked. From the subpage there is a redirect to the domain root which is then diverting the client to the gambling site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants