Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is considered a parameter? #359

Open
larshp opened this issue Dec 20, 2024 · 0 comments
Open

What is considered a parameter? #359

larshp opened this issue Dec 20, 2024 · 0 comments
Labels
Clarity of Text The issue or pull request helps to improve the clarity of the text clean-abap

Comments

@larshp
Copy link
Contributor

larshp commented Dec 20, 2024

Relevant sections of the style guide
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#keep-single-parameter-calls-on-one-line

Question
in

result = some_method_call( VALUE #( FOR i = 2 UNTIL i > 4 ( strings[ i ] ) ) ).

I'd say some_method_call has one parameter, and there are no additional calls, but SAP has chosen this to be formatted as

result = some_method_call( VALUE #( FOR i = 2 UNTIL i > 4
                                    ( strings[ i ] ) ) ).

which goes against the rule? What is considered a parameter and what is not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clarity of Text The issue or pull request helps to improve the clarity of the text clean-abap
Projects
None yet
Development

No branches or pull requests

1 participant