Merge branch 'dev' into issue_774/add-support-sql-server-2008-2014

Author: jeffrosenberg

DatabaseRestore.sql

@@ -28,15 +28,11 @@ EXEC dbo.DatabaseRestore
 	@RunRecovery = 1;
 */
 
-USE [master]
+IF OBJECT_ID('dbo.sp_DatabaseRestore') IS NULL
+  EXEC ('CREATE PROCEDURE dbo.sp_DatabaseRestore AS RETURN 0;')
 GO
 
-SET ANSI_NULLS ON
-GO
-SET QUOTED_IDENTIFIER ON
-GO
-
-CREATE PROCEDURE [dbo].[DatabaseRestore]
+ALTER PROCEDURE [dbo].[sp_DatabaseRestore]
 	  @Database NVARCHAR(128), @RestoreDatabaseName NVARCHAR(128) = NULL, @BackupPathFull NVARCHAR(MAX), @BackupPathLog NVARCHAR(MAX),
 	  @MoveFiles bit = 0, @MoveDataDrive NVARCHAR(260) = NULL, @MoveLogDrive NVARCHAR(260) = NULL, @TestRestore bit = 0, @RunCheckDB bit = 0, 
 	  @ContinueLogs bit = 0, @RunRecovery bit = 0
@@ -46,8 +42,6 @@ SET NOCOUNT ON;
 DECLARE @cmd NVARCHAR(4000), @sql NVARCHAR(MAX), @LastFullBackup NVARCHAR(500), @BackupFile NVARCHAR(500);
 DECLARE @FileList TABLE (BackupFile NVARCHAR(255));
 
-DECLARE @MoveDataLocation AS NVARCHAR(500), @MoveDataLocationName AS NVARCHAR(500), @MoveLogLocation AS NVARCHAR(500), @MoveLogLocationName AS NVARCHAR(500);
-
 IF @RestoreDatabaseName IS NULL
 	SET @RestoreDatabaseName = @Database;
 
@@ -67,7 +61,6 @@ WHERE BackupFile LIKE '%.bak'
 -- Get the SQL Server version number because the columns returned by RESTORE commands vary by version
 -- Based on: https://www.brentozar.com/archive/2015/05/sql-server-version-detection/
 -- Need to capture BuildVersion because RESTORE HEADERONLY changed with 2014 CU1, not RTM
-SELECT SERVERPROPERTY ('productversion')
 DECLARE @ProductVersion AS varchar(20) = CAST(SERVERPROPERTY ('productversion') AS varchar(20));
 DECLARE @MajorVersion AS smallint = CAST(PARSENAME(@ProductVersion, 4) AS smallint);
 DECLARE @MinorVersion AS smallint = CAST(PARSENAME(@ProductVersion, 3) AS smallint);
@@ -165,8 +158,8 @@ IF @MajorVersion >= 13 OR (@MajorVersion = 12 AND @BuildVersion >= 2342)
 
 SET @HeadersSQL += ')' + CHAR(13) + CHAR(10);
 SET @HeadersSQL += 'EXEC (''RESTORE HEADERONLY FROM DISK=''''{Path}'''''')';
-  
-DECLARE @MoveOption AS NVARCHAR(2000)= '';
+
+DECLARE @MoveOption AS NVARCHAR(MAX)= '';
 
 IF @MoveFiles = 1
 BEGIN
@@ -189,21 +182,23 @@ BEGIN
 	EXECUTE @sql = [dbo].[CommandExecute] @Command = @sql, @CommandType = 'RESTORE DATABASE', @Mode = 1, @DatabaseName = @Database, @LogToTable = 'Y', @Execute = 'Y';
 
 	--get the backup completed data so we can apply tlogs from that point forwards
+                                                        
   SET @sql = REPLACE(@HeadersSQL, '{Path}', @BackupPathFull + @LastFullBackup);
   PRINT @sql;
   EXECUTE (@sql);
 
-	DECLARE @BackupDateTime AS CHAR(15), @FullLastLSN numeric(25,0);
+	DECLARE @BackupDateTime AS CHAR(15), @FullLastLSN NUMERIC(25, 0);
 
 	SELECT @BackupDateTime = RIGHT(@LastFullBackup, 19)
 
-	SELECT @FullLastLSN = CAST(LastLSN AS numeric(25,0)) FROM #Headers WHERE BackupType = 1;
+	SELECT @FullLastLSN = CAST(LastLSN AS NUMERIC(25, 0)) FROM #Headers WHERE BackupType = 1;
+                                                        
 END;
 ELSE
 BEGIN
-	DECLARE @DatabaseLastLSN BIGINT;
+	DECLARE @DatabaseLastLSN NUMERIC(25, 0);
 
-	SELECT @DatabaseLastLSN = CAST(f.redo_start_lsn AS BIGINT)
+	SELECT @DatabaseLastLSN = CAST(f.redo_start_lsn AS NUMERIC(25, 0))
 	FROM master.sys.databases d
 	JOIN master.sys.master_files f ON d.database_id = f.database_id
 	WHERE d.name = @RestoreDatabaseName AND f.file_id = 1
@@ -226,7 +221,7 @@ DECLARE BackupFiles CURSOR FOR
 
 OPEN BackupFiles;
 
-DECLARE @i tinyint = 1, @LogFirstLSN numeric(25,0), @LogLastLSN numeric(25,0);
+DECLARE @i tinyint = 1, @LogFirstLSN NUMERIC(25, 0), @LogLastLSN NUMERIC(25, 0);
 
 -- Loop through all the files for the database  
 FETCH NEXT FROM BackupFiles INTO @BackupFile;
@@ -238,7 +233,7 @@ BEGIN
     PRINT @sql;
     EXECUTE (@sql);
 
-		SELECT @LogFirstLSN = CAST(FirstLSN AS numeric(25,0)), @LogLastLSN = CAST(LastLSN AS numeric(25,0)) FROM #Headers WHERE BackupType = 2;
+		SELECT @LogFirstLSN = CAST(FirstLSN AS NUMERIC(25, 0)), @LogLastLSN = CAST(LastLSN AS NUMERIC(25, 0)) FROM #Headers WHERE BackupType = 2;
 
 		IF (@ContinueLogs = 0 AND @LogFirstLSN <= @FullLastLSN AND @FullLastLSN <= @LogLastLSN) OR (@ContinueLogs = 1 AND @LogFirstLSN <= @DatabaseLastLSN AND @DatabaseLastLSN < @LogLastLSN)
 			SET @i = 2;

Documentation/Development/ReleaseProcess.md

@@ -22,7 +22,7 @@ Well, useful is probably the wrong word. More like entertaining. Here we go.
     * Run _TestBed.sql: this has stored proc calls with common parameters. May have to add in new scenarios if new features are added. 
 * If it passes, bump all the version numbers inside the scripts.
     * sp_foreachdb (no version number yet)
-    * sp_BlitzWho (no version number yet)
+    * sp_BlitzWho @Version and @VersionDate
     * sp_BlitzIndex @Version and @VersionDate
     * sp_BlitzFirst @VersionDate (no version) 
     * sp_BlitzCache @Version and @VersionDate 

Documentation/Development/_TestBed.sql

@@ -21,6 +21,13 @@ EXEC sp_BlitzIndex @DatabaseName = 'StackOverflow', @Mode = 4, @SkipPartitions =
 
 EXEC sp_BlitzIndex @DatabaseName = 'ChangeMe', @Mode = 4, @SkipPartitions = 0, @SkipStatistics = 0
 
+EXEC sp_BlitzIndex @GetAllDatabases = 1, @Mode = 1
+
+EXEC sp_BlitzIndex @GetAllDatabases = 1, @Mode = 2
+
+EXEC sp_BlitzIndex @GetAllDatabases = 1, @Mode = 3
+
+
 /*BlitzCache*/
 EXEC sp_BlitzCache @SortOrder = 'all'
 

sp_Blitz.sql

@@ -32,7 +32,7 @@ AS
 	SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 	DECLARE @Version VARCHAR(30);
 	SET @Version = '5.0';
-	SET @VersionDate = '20170301';
+	SET @VersionDate = '20170307';
 	SET @OutputType = UPPER(@OutputType);
 
 	IF @Help = 1 PRINT '
@@ -278,6 +278,15 @@ AS
 						INSERT INTO #SkipChecks (CheckID) VALUES (181);
 			END /* Amazon RDS skipped checks */
 
+		/* If the server is ExpressEdition, skip checks that it doesn't allow */
+		IF CAST(SERVERPROPERTY('Edition') AS NVARCHAR(1000)) LIKE N'%Express%'
+			BEGIN
+						INSERT INTO #SkipChecks (CheckID) VALUES (30); /* Alerts not configured */
+						INSERT INTO #SkipChecks (CheckID) VALUES (31); /* Operators not configured */
+						INSERT INTO #SkipChecks (CheckID) VALUES (61); /* Agent alerts 19-25 */
+						INSERT INTO #SkipChecks (CheckID) VALUES (73); /* Failsafe operator */
+						INSERT INTO #SkipChecks (CheckID) VALUES (96); /* Agent alerts for corruption */
+			END /* Express Edition skipped checks */
 
 
 		/*