Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated build_function #212

Open
Vaibhavdixit02 opened this issue Apr 23, 2021 · 3 comments
Open

Use updated build_function #212

Vaibhavdixit02 opened this issue Apr 23, 2021 · 3 comments

Comments

@Vaibhavdixit02
Copy link
Member

Vaibhavdixit02 commented Apr 23, 2021

Looks like Symbolics has deprecated use of build_function(<:Array{Equation}) and needs an array of Nums(/Terms ?). We should update our use of it here.

@ChrisRackauckas
Copy link
Member

Why would we do it on a Vector{Syms}? Seems odd?

@Vaibhavdixit02
Copy link
Member Author

Oh I meant Array{Equation} https://github.com/JuliaSymbolics/Symbolics.jl/blob/5708f21726cefb0029b0900eafbf5bed23bbd266/src/build_function.jl#L458. And that's the deprecated one, not asking for it, just opened this to track that we update here

@ChrisRackauckas
Copy link
Member

Oh yes, Array{Equation} was only ever implemented for the Stan and MATLAB ones, so they were kind of weird. We should be doing build_function on the .rhs. That needs to bubble into what happens automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants