requests(CreateSource): use the OBSSourceAutoRelease container instead of manipulating refs manually

Palakis · Palakis · commit 08178b93542e · 2020-11-27T19:40:02.000+01:00
diff --git a/src/WSRequestHandler_Sources.cpp b/src/WSRequestHandler_Sources.cpp
@@ -58,7 +58,7 @@ RpcResponse WSRequestHandler::CreateSource(const RpcRequest& request)
 		return request.failed("requested scene is invalid or doesnt exist");
 	}
 
-	obs_source_t *newSource = obs_source_create(sourceKind.toUtf8(), sourceName.toUtf8(), nullptr, nullptr);
+	OBSSourceAutoRelease newSource = obs_source_create(sourceKind.toUtf8(), sourceName.toUtf8(), nullptr, nullptr);
 
 	if (!newSource) {
 		return request.failed("failed to create the source");
@@ -85,7 +85,6 @@ RpcResponse WSRequestHandler::CreateSource(const RpcRequest& request)
 	OBSDataAutoRelease responseData = obs_data_create();
 	obs_data_set_int(responseData, "itemId", obs_sceneitem_get_id(data.sceneItem));
 
-	obs_source_release(newSource);
 	return request.success(responseData);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ RpcResponse WSRequestHandler::CreateSource(const RpcRequest& request)`
`58`	`58`	`return request.failed("requested scene is invalid or doesnt exist");`
`59`	`59`	`}`
`60`	`60`
`61`		`- obs_source_t *newSource = obs_source_create(sourceKind.toUtf8(), sourceName.toUtf8(), nullptr, nullptr);`
	`61`	`+ OBSSourceAutoRelease newSource = obs_source_create(sourceKind.toUtf8(), sourceName.toUtf8(), nullptr, nullptr);`
`62`	`62`
`63`	`63`	`if (!newSource) {`
`64`	`64`	`return request.failed("failed to create the source");`
`@@ -85,7 +85,6 @@ RpcResponse WSRequestHandler::CreateSource(const RpcRequest& request)`
`85`	`85`	`OBSDataAutoRelease responseData = obs_data_create();`
`86`	`86`	`obs_data_set_int(responseData, "itemId", obs_sceneitem_get_id(data.sceneItem));`
`87`	`87`
`88`		`- obs_source_release(newSource);`
`89`	`88`	`return request.success(responseData);`
`90`	`89`	`}`
`91`	`90`