Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regex rules: rewrite rules using negative lookahead #1

Open
Shaked opened this issue Feb 7, 2014 · 0 comments
Open

Regex rules: rewrite rules using negative lookahead #1

Shaked opened this issue Feb 7, 2014 · 0 comments
Labels
bug

Comments

@Shaked
Copy link
Owner

Shaked commented Feb 7, 2014

Golang uses re2 regular expression library while the rules are written for PCRE.

At the moment there are 3 rules that are effected by this issue:

`NexusTablet`:   `^.*Android.*Nexus(((?:(?!Mobile))|(?:(\s(7|10).+))).)*$`,
`AsusTablet`:     `^.*PadFone((?!Mobile).)*$|Transformer|TF101|TF101G|TF300T|TF300TG|TF300TL|TF700T|TF700KL|TF701T|TF810C|ME171|ME301T|ME302C|ME371MG|ME370T|ME372MG|ME172V|ME173X|ME400C|Slider SL101|\bK00F\b|TX201LA`,
`GenericTablet`: `Android.*\b97D\b|Tablet(?!.*PC)|ViewPad7|BNTV250A|MID-WCDMA|LogicPD Zoom2|\bA7EB\b|CatNova8|A1_07|CT704|CT1002|\bM721\b|rk30sdk|\bEVOTAB\b|SmartTabII10|SmartTab10|M758A|ET904|ALUMIUM10`,
Shaked added a commit that referenced this issue Feb 7, 2014
@Shaked
fixed some issues with initiation, now possible to initiate with defa…
bf52da4 
…ult rules. commented out negative lookahead regex regarding to issue #1
@Shaked Shaked added the bug label Feb 7, 2014
Shaked added a commit that referenced this issue May 5, 2014
@Shaked
skip tests regarding issue #1
afa83fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Shaked