Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: dev-server HotReload event #3493

Open
eloyesp opened this issue Feb 27, 2024 · 3 comments
Open

[Feature]: dev-server HotReload event #3493

eloyesp opened this issue Feb 27, 2024 · 3 comments
Labels
Area: @shopify/theme @shopify/theme package issues moderate lowest severity for theme related bug open for contributions theme bugs that won't be prioritized in the near future Type: Enhancement New feature or request

Comments

@eloyesp
Copy link

eloyesp commented Feb 27, 2024

What area(s) will this request affect?

Running your code locally

What type of change do you want to see?

New feature

Overview

There is a script for HotReload that is embedded on the html on the development server: 'theme_extension.js', it would be nice to have a custom refresh event being triggered to make sure that non-idempotent javascript can run again.

Motivation

When themes with many scripts that depend on 'onload' event, hotreload is not great.

Copy link
Contributor

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

Copy link
Contributor

github-actions bot commented Jul 4, 2024

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

Copy link
Contributor

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

@karreiro karreiro added #gsd:40767 Fortify local development experience for Liquid themes moderate lowest severity for theme related bug open for contributions theme bugs that won't be prioritized in the near future and removed no-issue-activity #gsd:40767 Fortify local development experience for Liquid themes labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/theme @shopify/theme package issues moderate lowest severity for theme related bug open for contributions theme bugs that won't be prioritized in the near future Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants