Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: GitIgnore .shopify equivalents are ignored #5286

Open
2 tasks done
PhoneDroid opened this issue Jan 28, 2025 · 1 comment
Open
2 tasks done

[Bug]: GitIgnore .shopify equivalents are ignored #5286

PhoneDroid opened this issue Jan 28, 2025 · 1 comment
Assignees
Labels
Area: @shopify/theme @shopify/theme package issues Type: Bug Something isn't working

Comments

@PhoneDroid
Copy link

PhoneDroid commented Jan 28, 2025

Please confirm that you have:

  • Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

Theme

Expected behavior

.shopify isn't added to .gitignore when equivalent entries are present.

Actual behavior

.shopify is added to .gitignore when valid entries are present.

Examples of valid entries:

  • ./.shopify
  • ./.shopify/**
  • .shopify/**

Relevant code to the problem :

export function addToGitIgnore(root: string, entry: string): void {

Verbose output

Irrelevant

Reproduction steps

  1. Any theme repository without .shopify folder
  2. Gitignore with one of the valid entries
  3. Run shopify theme metafields pull

Operating System

Kubuntu 24.04

Shopify CLI version (shopify --version)

@shopify/cli/3.74.1 linux-x64 node-v22.12.0

Shell

No response

Node version (run node -v if you're not sure)

No response

What language and version are you using in your application?

No response

@PhoneDroid PhoneDroid added the Type: Bug Something isn't working label Jan 28, 2025
@graygilmore
Copy link
Contributor

Thanks for the report @PhoneDroid! We'll look at addressing this.

@karreiro karreiro added the Area: @shopify/theme @shopify/theme package issues label Jan 29, 2025
@karreiro karreiro self-assigned this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/theme @shopify/theme package issues Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants