-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent named imports for RHP packages #1678
Comments
Hi @ChrisSchinnerl I'm interested in this issue, I scanned through other repos owned by siafoundation (explored, hosted, cluster, benchmark) for the naming conventions of rhp imports and here are my findings.
Before I make a PR I would like your opinion on how I should approach the renaming process since there isn't really a clear convention throughout the various repositories I went through. The approach I came up with was to use |
@ahuangg thanks for your help! This is super helpful already. It seems like you listed I think we can agree on We could do
|
Right now we use
rhp
,rhpvX
,rhpX
and potentially other names pretty inconsistently for importing the pathsgo.sia.tech/core/rhp/vX
,go.sia.tech/coreutils/rhp/vX
andgo.sia.tech/renterd/internal/rhp/vX
.We should correct that to be consistent about the name each import gets. I think outside of
renterd
we are mostly consistent so it's a good idea to check the other repos first and reuse the conventions if possible.The text was updated successfully, but these errors were encountered: