Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken multiline function signature #388

Closed
bytequill opened this issue Feb 2, 2025 · 2 comments
Closed

Broken multiline function signature #388

bytequill opened this issue Feb 2, 2025 · 2 comments
Assignees
@SpartanJ
Labels
bug Something isn't working ready for release

Comments

@bytequill
Copy link

Some functions have a function signature which breaks the display:
Image

I assume that due to the multiline structure of the original signature (as seen in the source), which the lsp reports as such but the renderer is only built for single line. I suggest for the renderer to try to compress the signature into a single line as to not cover the code currently being written.
@SpartanJ
Copy link
Owner

SpartanJ commented Feb 2, 2025

Oh, I see, this is the first time an LSP reporting a multi-line signature help, I'll fix it today. Thanks.

@SpartanJ SpartanJ self-assigned this Feb 2, 2025
@SpartanJ SpartanJ added the bug Something isn't working label Feb 2, 2025
SpartanJ added a commit to SpartanJ/eepp that referenced this issue Feb 2, 2025
@SpartanJ
Fix for multi-line signature help labels, now labels will be flatten …
d3bc6f2 
…into a single line (SpartanJ/ecode#388).

Fix next signature help position.
Fix signature help and suggestions styles for light color schemes, and some minor improvements for other schemes.
Allow to set extra trigger characters for signature help in LSP configurations (fix zig zls not updating signature position after a "," input).
Plus some other minor fixes.
@SpartanJ
Copy link
Owner

SpartanJ commented Feb 2, 2025

Fix is available in the nightly builds.

@SpartanJ SpartanJ closed this as completed Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SpartanJ SpartanJ

Labels
bug Something isn't working ready for release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SpartanJ @bytequill