Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an operator, webhook checkout.session.completed mode 'setup' upon update payment method is handled gracefully #1400

Closed
chrisjsimpson opened this issue Sep 3, 2024 · 2 comments
Labels
released This issue/pull request has been released.

Comments

@chrisjsimpson
Copy link
Contributor

Is your feature request related to a problem? Please describe.

When subscriber payment details are updated, this suceeds (because payment details are not persisted by subscribie, they are persisted by the payment provider (e.g. stripe), however the webhook does not correctly return 200 causing that webhook type & mode (setup) combination to return a 500 response.

subscribie/blueprints/checkout/__init__.py", line 1059, in stripe_webhook
    currency = session["currency"].upper()
               ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'upper'

Describe the solution you'd like

Handle checkout.session.completed mode type setup events correctly with a 200 response.

Describe alternatives you've considered

Additional context

Copy link

github-actions bot commented Sep 3, 2024

🚀 Issue was released in v0.1.205 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

🚀 Issue was released in v0.1.205 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

No branches or pull requests

1 participant