New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Restore cancel_at being set for new subscriptions #1437

Closed

chrisjsimpson opened this issue Jan 22, 2025 · 33 comments

Labels

released

Contributor

chrisjsimpson commented Jan 22, 2025

Is your feature request related to a problem? Please describe.

A refactor in update_subscription statuses, caused cancel_at not being set on new plans if this setting was chosen (and missing test which exists , @516_subscriber_order_plan_with_cancel_at but was missing from automated test runs).

Describe the solution you'd like

restore cancel_at and include test in test run.

Describe alternatives you've considered

Additional context

TODO add consistency to test run naming so that inclusion of all existing tests may be valitated automatically (missing no tests).

The text was updated successfully, but these errors were encountered:

chrisjsimpson added a commit that referenced this issue


          wip 1133 Fix #1437 restore cancel_at plans feature including test

e394e1f

chrisjsimpson added a commit that referenced this issue


          Fix #1437 add shebang allow run-playwright-tests.py to be ran as scri…

47c14cf

…pt, verified all tests pass

chrisjsimpson added a commit that referenced this issue


          Fix #1437 show "Automatically cancels at" below "Date started" on pla…

ef1c274

…ns which have cancel_at date set

chrisjsimpson added a commit that referenced this issue


          #1437 show cancel_at on show_subscriber view

d2b7fad

chrisjsimpson added a commit that referenced this issue


          #1437 correct case of test asserting text="Automatically cancels at:"

fdcb1a8

chrisjsimpson closed this as completed in

1967e18

chrisjsimpson added a commit that referenced this issue


          Fix #1437 add shebang allow run-playwright-tests.py to be ran as scri…

348e8c8

…pt, verified all tests pass

chrisjsimpson added a commit that referenced this issue


          Fix #1437 show "Automatically cancels at" below "Date started" on pla…

285aa41

…ns which have cancel_at date set

chrisjsimpson added a commit that referenced this issue


          #1437 show cancel_at on show_subscriber view

1d8ab13

chrisjsimpson added a commit that referenced this issue


          #1437 correct case of test asserting text="Automatically cancels at:"

543c2d5

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

6 similar comments

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot added the released label

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

11 similar comments

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

13 similar comments

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

github-actions bot commented Jan 22, 2025

🚀 Issue was released in v0.1.225 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment