Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate removing theme create #157

Open
jeffreyguenther opened this issue Jan 20, 2025 · 4 comments
Open

Evaluate removing theme create #157

jeffreyguenther opened this issue Jan 20, 2025 · 4 comments

Comments

@jeffreyguenther
Copy link
Contributor

jeffreyguenther commented Jan 20, 2025

Depending on changes to the theme push command, it might be possible to remove this command.

It only exists because push was not idempotent.

@jeffreyguenther
Copy link
Contributor Author

Still needed sadly. shopify theme push --unpublished creates many themes with the same name.

@jeffreyguenther
Copy link
Contributor Author

@jamesmengo is there any appetite to fix Shopify/cli#2699? Missed catching the stale bot, but this issues still persists.

Based on my current testing, it's still possible to create many themes of the same name. This is less than ideal for people who want to create themes via a GitHub Action. In my experience it's a bit of a surprise.

I understand why its allowed based on the Shopify Online Store UI experience because names don't specify unique themes. IDs do.

I think adding a flag to make the push command idempotent would make many a dev happy. I know enough how things work internally to open a PR.

@jamesmengo
Copy link

@jeffreyguenther would definitely be open to reviewing a PR adding this functionality!

@jeffreyguenther
Copy link
Contributor Author

Standby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants