Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANMAP does not work in channel map mode because of a code bug #43

Closed
iflyhigh opened this issue Feb 15, 2023 · 2 comments
Closed

CHANMAP does not work in channel map mode because of a code bug #43

iflyhigh opened this issue Feb 15, 2023 · 2 comments

Comments

@iflyhigh
Copy link

The code below is missing else statement after the second if. Currently it causes any pipe with CHANMAP set to channel map (i.e. ==0) mode just to drop the MIDI message because the last if fires unconditionally, returns false thus the whole function returns false. Observed live in my setup.

mod_miditransfn_pipes.h
...
  // Map channel to channel
  if (pipe->par1 == 0 ) {
...
  }
  else
  // Map channel to port (of the same port type)
  if (pipe->par1 == 1 ) {
...
  }
  // channel offset
  if (pipe->par1 == 2 ) {
...
  }
  else return false; // Error
@TheKikGen
Copy link
Owner

Hi. Thanks for that. You are right. Else is missing here. could you push a change request, so you will appear in contributors list :-) !

@TheKikGen
Copy link
Owner

TheKikGen commented Feb 26, 2023

Forget. I did it...Thanks for pointing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants