Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark report perf summary: go to zero #328

Open
ge0ffrey opened this issue Oct 10, 2023 · 3 comments
Open

Benchmark report perf summary: go to zero #328

ge0ffrey opened this issue Oct 10, 2023 · 3 comments
Assignees
@triceo
Labels
enhancement New feature or request papercut

Comments

@ge0ffrey
Copy link
Contributor

image
the Y axis should go to zero
@ge0ffrey ge0ffrey added bug Something isn't working process/needs triage Requires initial assessment of validity, priority etc. labels Oct 10, 2023
@triceo
Copy link
Contributor

triceo commented Oct 10, 2023

I experimented with that when I was creating this report.
In this case, it looks like a good idea.
In many other cases, "go to zero" creates an empty chart with a flat line at the top, because the difference is very small and/or very far away from zero.

@ge0ffrey
Copy link
Contributor Author

Yes, I would compare with the old benchmark report - when to include 0 depends on the statistic.

@triceo triceo added enhancement New feature or request and removed process/needs triage Requires initial assessment of validity, priority etc. labels Oct 11, 2023
@triceo triceo self-assigned this Oct 11, 2023
@triceo triceo removed the bug Something isn't working label Oct 12, 2023
@ge0ffrey
Copy link
Contributor Author

When it's a flat line on the top, that's what I want to see: it shows the differences don't really matter.
Currently the new perf graph is misleading because it's not zero based.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@triceo triceo

Labels
enhancement New feature or request papercut
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ge0ffrey @triceo