From 29310ae43aa7a33ef74c227f4ef81b7409234dbc Mon Sep 17 00:00:00 2001 From: Khushal Sagar Date: Mon, 10 Jul 2023 12:04:06 -0700 Subject: [PATCH] view-transitions: Ensure root element generates group animations. This change aligns the implementation for tracking state and generating styles for the root element with sub-elements. This aligns well with the spec and ensures the behaviour for root transitions stays consistent with element transitions. Specifically, we now generate animations for the group pseudo corresponding to the root. This means we now have a no-op animation for the root. While this aligns with the spec, it should be optimized going forward. R=vmpstr@chromium.org Bug: 1454863, 1457298 Change-Id: I3ea09dd0f021675875f2aabf911421e8810f8465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4668328 Reviewed-by: Dave Tapuska Auto-Submit: Khushal Sagar Reviewed-by: Vladimir Levin Commit-Queue: Khushal Sagar Cr-Commit-Position: refs/heads/main@{#1168240} --- .../group-animation-for-root-transition.html | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 css/css-view-transitions/group-animation-for-root-transition.html diff --git a/css/css-view-transitions/group-animation-for-root-transition.html b/css/css-view-transitions/group-animation-for-root-transition.html new file mode 100644 index 00000000000000..7224d8ddf586c2 --- /dev/null +++ b/css/css-view-transitions/group-animation-for-root-transition.html @@ -0,0 +1,42 @@ + + +View transitions: group pseudo for the root transition has animation + + + + + + +