Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] New version of attrs got an mypy checking error #115

Closed
shenxiangzhuang opened this issue Aug 6, 2024 · 4 comments · Fixed by #116
Closed

[BUG] New version of attrs got an mypy checking error #115

shenxiangzhuang opened this issue Aug 6, 2024 · 4 comments · Fixed by #116
Labels
bug Something isn't working

Comments

@shenxiangzhuang
Copy link
Contributor

shenxiangzhuang commented Aug 6, 2024

Observed behavior

Got mypy error in #114 ci execution:

crowdkit/aggregation/utils.py:194: error: Returning Any from function declared to return "Series[Any]"  [no-any-return]
Found 1 error in 1 file (checked 79 source files)

The error is caused by the new version of attrs.

We can reproduce the error by using the newest 24.1.0 version of attrs, and it's ok in old attrs version(23.2.0)

Expected behavior

No response

Python Version

3.8

Crowd-Kit Version

1.3.0.post0

Other Packages Versions

attrs==24.1.0

Example code

Relevant log output

No response

@shenxiangzhuang
Copy link
Contributor Author

shenxiangzhuang commented Aug 8, 2024

I found the ci still fail after merged this pr into main: https://github.com/Toloka/crowd-kit/actions/runs/10292704472

Is cache in github action the reason? I don't know why ci in pr runs fine but fails in master branch...

@dustalov
Copy link
Collaborator

dustalov commented Aug 8, 2024

I noticed that the problem was caused by the NumPy version 2.0 which was unavailable for Python 3.8 and older versions. I will exclude the impacted checks from CI.

@dustalov
Copy link
Collaborator

dustalov commented Aug 8, 2024

Please try again against the newer revision of main.

@shenxiangzhuang
Copy link
Contributor Author

shenxiangzhuang commented Aug 8, 2024

Thanks, I'll try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants