Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect documentation reference #3

Closed
TanVD opened this issue Sep 2, 2021 · 2 comments · Fixed by #9
Closed

Incorrect documentation reference #3

TanVD opened this issue Sep 2, 2021 · 2 comments · Fixed by #9
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@TanVD
Copy link

TanVD commented Sep 2, 2021

crowd-kit/src/aggregation/closest_to_average.py

Line 19 in 2c81ae1

scores_: annotations.TASKS_LABEL_PROBAS

It looks like there should be TASK_LABEL_SCORES, not TASK_LABEL_PROBAS. Scores definitely would not sum up to 1.
@Losik Losik added the documentation Improvements or additions to documentation label Sep 2, 2021
@Losik
Copy link
Contributor

Losik commented Sep 2, 2021

Thank you for noticing! After a closer look I've found that docstring for ClosestToAverage is also misleading.

@Losik Losik added the good first issue Good for newcomers label Sep 24, 2021
@Losik Losik mentioned this issue Oct 5, 2021
Merged
@Losik Losik linked a pull request Oct 5, 2021 that will close this issue
Fix docstring issue #9
Merged
Losik added a commit that referenced this issue Oct 5, 2021
@Losik
Merging issues fixes and readme update
2231fb2 
* README update
* Fix for Dawid-Skene issue with number-named columns #6
* Fix for incorrect annotation and documentation for `scores_` in `ClosestToAverage` #3
* Stub-files update
@Losik
Copy link
Contributor

Losik commented Oct 15, 2021

Fixed in crowd-kit==0.0.8

@Losik Losik closed this as completed Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix docstring issue Toloka/crowd-kit
2 participants
@Losik @TanVD