Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix h1 in Hero section on mobile #496

Open
JVSONV opened this issue Aug 8, 2023 · 3 comments · Fixed by #498
Open

Fix h1 in Hero section on mobile #496

JVSONV opened this issue Aug 8, 2023 · 3 comments · Fixed by #498
Assignees
@JVSONV

Comments

@JVSONV
Copy link
Collaborator

JVSONV commented Aug 8, 2023

h1 Tag within the hero section on the landing page on mobile constantly resizes due to typing animation. Implement a fix to prevent the h1 from colliding with other adjacent elements.
@JVSONV JVSONV linked a pull request Aug 8, 2023 that will close this issue
Hero h1 tag fix #498
Merged
@JVSONV JVSONV mentioned this issue Aug 8, 2023
Merged
@JVSONV
Copy link
Collaborator Author

JVSONV commented Aug 8, 2023

I'd like to suggest that we add a slight black overlay on the background image to help boost the text color contrast ratio.

@jeromehardaway jeromehardaway reopened this Aug 8, 2023
@JVSONV JVSONV self-assigned this Aug 8, 2023
@jeromehardaway
Copy link
Contributor

@JVSONV you solved this one already right?

@JVSONV
Copy link
Collaborator Author

JVSONV commented Oct 17, 2023

Yes I believe it should be working correctly. I went back and saw the issues you stated after the initial fix. My second fix should rectify this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JVSONV JVSONV

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hero h1 tag fix Vets-Who-Code/vets-who-code-app
2 participants
@jeromehardaway @JVSONV