Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: WeTransfer/format_parser
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: WeTransfer/format_parser
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: id3tag-bug
Choose a head ref
  • 4 commits
  • 10 files changed
  • 1 contributor

Commits on May 10, 2018

  1. Replace homegworn ID3 parser with id3tag 

    id3tag is a mature library, it has version constraints similar to ours,
and it is compatible with our IO model. We could of course continue
torturing ourselves with a custom parser, but for this - just as is the case
for EXIF - using a third-party library makes sense. We keep it isolated from
our IO stack by passing it prepackaged buffers.
    @julik
    julik committed May 10, 2018
    Configuration menu
    Copy the full SHA
    3ef9023 View commit details
    Browse the repository at this point in the history

  2. Make sure we do not read huge ID3 tags 

    We got to set limits somewhere
    @julik
    julik committed May 10, 2018
    Configuration menu
    Copy the full SHA
    58eea2b View commit details
    Browse the repository at this point in the history

  3. Make sure JSON generates cleanly for MP3

    @julik
    julik committed May 10, 2018
    Configuration menu
    Copy the full SHA
    0052717 View commit details
    Browse the repository at this point in the history

  4. Demonstrate the bug

    @julik
    julik committed May 10, 2018
    Configuration menu
    Copy the full SHA
    330f834 View commit details
    Browse the repository at this point in the history
Loading