Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name parameter is not needed for GET credentials by SAID endpoint #142

Closed
lenkan opened this issue Dec 5, 2023 · 2 comments
Closed

Name parameter is not needed for GET credentials by SAID endpoint #142

lenkan opened this issue Dec 5, 2023 · 2 comments

Comments

@lenkan
Copy link
Collaborator

lenkan commented Dec 5, 2023

Similarly what was changed here: #128, the name parameter is not used for GET /identifiers/{name}/credentials/{said} endpoint. See here:

def on_get(req, rep, name, said):

We only check that the name is a valid hab for this agent, then we proceed without using the hab. I suggest to move the endpoint to be

GET /credentials/{said}

to avoid having to pass the redundant name parameter when you have the credential id.

@m00sey
Copy link
Member

m00sey commented Dec 14, 2023

Suggestion to remove name param

@lenkan
Copy link
Collaborator Author

lenkan commented Feb 13, 2024

Fixed by #179

@lenkan lenkan closed this as completed Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants