Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Bar: Can't open edit dropdown with a keyboard #273

Closed
ryelle opened this issue Sep 16, 2022 · 0 comments
Closed

Admin Bar: Can't open edit dropdown with a keyboard #273

ryelle opened this issue Sep 16, 2022 · 0 comments
Assignees
Labels
Accessibility Issues related to keyboard navigation, screen readers, etc [Block] Header & Footer

Comments

@ryelle
Copy link
Contributor

ryelle commented Sep 16, 2022

It appears that the 'Edit' options are no longer accessible from the keyboard since this change. @alexstine, the Make/Accessibility team rep noted this because it significantly broke his workflow to not be able to reach the 'Edit Post' submenu while posting agendas & meeting notes.

I haven't explored thoroughly, but I think it broke the event handlers in /js/_enqueus/lib/admin-bar.js

From #256 (comment)

The top-level edit "link" is not a link, so it doesn't get focus, which means the submenu can't open via keyboard. "Edit [object]" is a common use, so this should probably go back to being a top-level item anyway (see #271).

@ryelle ryelle added Accessibility Issues related to keyboard navigation, screen readers, etc [Block] Header & Footer labels Sep 16, 2022
@ryelle ryelle self-assigned this Sep 16, 2022
@ryelle ryelle closed this as completed in 9610421 Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues related to keyboard navigation, screen readers, etc [Block] Header & Footer
Projects
None yet
Development

No branches or pull requests

1 participant