Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-canonical category names for BG hero portraits #168

Open
piedpiper358 opened this issue Aug 28, 2022 · 1 comment
Open

Non-canonical category names for BG hero portraits #168

piedpiper358 opened this issue Aug 28, 2022 · 1 comment

Comments

@piedpiper358
Copy link
Contributor

piedpiper358 commented Aug 28, 2022 •
edited
Loading

When viewing missing BG hero portraits, the category gets the name of the first portrait, which is always non-canonical. Therefore, we should first group the portraits (so that name of canonical portrait becomes the name of the category) and then filter out the portraits that the user doesn't have.

2022-10-14_21-11-08
@sebastientromp
Copy link
Contributor

Agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebastientromp @piedpiper358