Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add wagmi config to marketsConfig #2345

Closed
5 tasks
CanonicalJP opened this issue Feb 12, 2025 · 2 comments · Fixed by #2344
Closed
5 tasks

feat: add wagmi config to marketsConfig #2345

CanonicalJP opened this issue Feb 12, 2025 · 2 comments · Fixed by #2344
Assignees
Labels
feature New feature or request new issue This issue has not been triaged by the core team yet

Comments

@CanonicalJP
Copy link
Contributor

General Changes

  • add the wagmi config from src/ui-config/wagmiConfig.ts to src/ui-config/marketsConfig.tsx to keep it in a single place

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)
@CanonicalJP CanonicalJP added feature New feature or request new issue This issue has not been triaged by the core team yet labels Feb 12, 2025
@SamarthJ2004
Copy link

Hi @CanonicalJP , I would like to work on this issue.

@grothem
Copy link
Collaborator

grothem commented Feb 12, 2025

Thanks @SamarthJ2004 but this one is already taken care of

@grothem grothem self-assigned this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request new issue This issue has not been triaged by the core team yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants