New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in error construction? #68

Open

Evgeny-A opened this issue Sep 6, 2017 · 1 comment

Evgeny-A commented Sep 6, 2017

Is this line correct?

jetfire/JFRWebSocket.m

Line 779 in 2a0811d

details[detail] = NSLocalizedDescriptionKey;

Shouldn't it be this way:

details[NSLocalizedDescriptionKey] = detail;

The text was updated successfully, but these errors were encountered:

Owner

acmacalister commented Oct 10, 2017

You are correct. I'm working on updating Jetfire to better match what we are doing in the Swift version, so I will roll this fix in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment