Skip to content

Commit 0b49642

Browse files
committed
pg_standby: Avoid writing one byte beyond the end of the buffer.
Previously, read() might have returned a length equal to the buffer length, and then the subsequent store to buf[len] would write a zero-byte one byte past the end. This doesn't seem likely to be a security issue, but there's some chance it could result in pg_standby misbehaving. Spotted by Coverity; patch by Michael Paquier, reviewed by me.
1 parent 6cfd508 commit 0b49642

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

contrib/pg_standby/pg_standby.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,7 @@ CheckForExternalTrigger(void)
418418
return;
419419
}
420420

421-
if ((len = read(fd, buf, sizeof(buf))) < 0)
421+
if ((len = read(fd, buf, sizeof(buf) - 1)) < 0)
422422
{
423423
fprintf(stderr, "WARNING: could not read \"%s\": %s\n",
424424
triggerPath, strerror(errno));

0 commit comments

Comments
 (0)