Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use process.exitCode instead of explicitly using process.exit #364

Open
shazron opened this issue Jan 21, 2021 · 0 comments
Open

Use process.exitCode instead of explicitly using process.exit #364

shazron opened this issue Jan 21, 2021 · 0 comments

Comments

@shazron
Copy link
Member

shazron commented Jan 21, 2021

In aio app run, we have a SIGINT handler, and we explicitly call process.exit after trying to clean up our resource usage. We should just set the appropriate exit code and let the program naturally exit.

However, something is not being cleaned up properly, thus the program does not exit. Will need to investigate the issue further.

See discussion here: #343 (comment)

@shazron shazron mentioned this issue Jan 21, 2021
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant