A-Painter memory leak (not just multi-user)

[avrljk]

We've modified A-Painter to support multi-user painting (including undo and clear).

Before submitting a pull request, we need to track down a memory leak.
At first we thought it was our code, but the leak also seems to appear in an unmodified copy of A-Painter.

Is anyone else seeing memory leaks cause Google Chrome "Aw, Snap!" errors in the A-Painter tab after about 10-15 minutes in VR mode with HTC Vive?

We typically paint for a minute or two then leave the Vive unattended and switch Chrome to another tab. Later, when we switch back to the A-Painter tab there's an "Aw, Snap!" waiting for us.

We'll try memory profiling and/or Firefox in the next day or two if nobody else is seeing this.

[fernandojsg]

@avrljk so nice to hear that you're working on it! I didn't get that error, but I'm going to give it a try to see if I can reproduce it and try to find what is causing it.
Thanks for reporting it!

[avrljk]

We saw the leak repeatedly on three separate Vive/PC setups during multi-user development & testing.

I've had trouble reproducing it on the only Vive/PC available to me so far this week.

I'm now wondering if the leak was in some upstream code A-Painter or the browser pulls in uses and it's been fixed. I was testing using the same Chrome build we developed with and whatever A-Painter build loads from this URL: https://aframe.io/a-painter/

I should have access to the other two Vives again in the next couple of days for some more comprehensive testing.

[avrljk]

Last week I couldn't reproduce the leak on two of the three original Vive systems we saw it on the week before.

One case I didn't have time to test was leaving an instance of (unmodified) A-Painter running in one tab of a browser window after starting another A-Painter instance (modified / unmodified) in a fresh tab of the same browser window.

I'm reopening this issue as a reminder to test that too.

We were holding back on releasing the code until we found the leak, but I think we can cry "Havoc!" and let slip the multi-users of A-Paint (with apologies to Shakespeare).

Over to you @mrfrase3.

[avrljk]

I saw a couple of crashes again during a recent demo of vanilla A-Painter (not multi-user) but didn't have time to chase it down at the time.
I'll try to find a repeatable way of generating a crash next week.

[pjoulot]

Hi, I don't know if it's related but I have some lags when I'm using A-Painter on Firefox with the HTC Vive and after a while it crashed. I tried the other A-Frame controller demo and it was working well.