-
Notifications
You must be signed in to change notification settings - Fork 7
Comparing changes
Open a pull request
base repository: ahrefs/monorobot
base: d983684f9baf73fa91c5ec0c5b83a9821f51dd5f
head repository: ahrefs/monorobot
compare: a3eea15e3cb380c78b951d2730fd4fb77c60d887
- 16 commits
- 28 files changed
- 1 contributor
Commits on Dec 24, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 52950a7 - Browse repository at this point
Copy the full SHA 52950a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d428ae - Browse repository at this point
Copy the full SHA 6d428aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for ba1679a - Browse repository at this point
Copy the full SHA ba1679aView commit details
Commits on Dec 28, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b31adf1 - Browse repository at this point
Copy the full SHA b31adf1View commit details
Commits on Dec 29, 2020
-
Merge branch 'hotfix/config-init-and-cli-flags'
* hotfix/config-init-and-cli-flags: prepend slash to commits_url fix check_gh payload and secrets initialization don't try to load state from file on startup if doesn't exist print config after initialization
Configuration menu - View commit details
-
Copy full SHA for c42b86f - Browse repository at this point
Copy the full SHA c42b86fView commit details -
move config and associated functions from context toplevel to state
The `Context` toplevel should only store relatively static info that applies globally, like the secrets. When we accommodate multiple repos, a particular repo's config should be moved out of the global toplevel context to the runtime `State`, where it can coexist with other dynamic, repo-specific info like pipeline status.
Configuration menu - View commit details
-
Copy full SHA for b9a0cd9 - Browse repository at this point
Copy the full SHA b9a0cd9View commit details -
make state a hash table mapping repo urls to repo-specific state
Repo state is namespaced by the full url of the repo, so that so that identifiers are unique across platforms (github.com and GH Enterprise).
Configuration menu - View commit details
-
Copy full SHA for 914406b - Browse repository at this point
Copy the full SHA 914406bView commit details -
modify tests to recreate context per test case
For each test case, initializes a repo state from file if one exists.
Configuration menu - View commit details
-
Copy full SHA for 6e5c4cc - Browse repository at this point
Copy the full SHA 6e5c4ccView commit details -
move generic map/table atd bindings into common.atd file
The bindings should be usable by any file, not just state.atd
Configuration menu - View commit details
-
Copy full SHA for fcbbcd6 - Browse repository at this point
Copy the full SHA fcbbcd6View commit details -
move webhook signature checking logic out of parse_exn
With repo-specific secrets, we'll need the repo name in order to obtain the webhook token used for signature validation. So parsing the request body for a GH payload needs to happen before, not after, the signature check.
Configuration menu - View commit details
-
Copy full SHA for c0831a9 - Browse repository at this point
Copy the full SHA c0831a9View commit details -
allow repo-specific configuration of gh_token and gh_hook_token
Define custom getters for retrieving GH secret values. As the getter for each token type defaults to looking for a global value if a repo-specific vaue isn't found, existing deployments don't need to change.
Configuration menu - View commit details
-
Copy full SHA for e2a6290 - Browse repository at this point
Copy the full SHA e2a6290View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0da4a40 - Browse repository at this point
Copy the full SHA 0da4a40View commit details -
Configuration menu - View commit details
-
Copy full SHA for bdaa5e8 - Browse repository at this point
Copy the full SHA bdaa5e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19cc0d1 - Browse repository at this point
Copy the full SHA 19cc0d1View commit details -
tests: load secrets and config files per test case
We can now configure secrets, config, state, and incoming payload separately, which lets us test multi-repo behavior more easily.
Configuration menu - View commit details
-
Copy full SHA for 753830d - Browse repository at this point
Copy the full SHA 753830dView commit details -
tests: add cases that check repo-specific config loading behavior
`push.multi_repo_custom_repo_secrets` The correct repo-specific secrets configuration should be loaded for the given payload repo. `status.multi_repo_disallowed_repo` If `allowed_repositories` excludes the payload repo, it should be ignored. `status.multi_repo_independent_status_state` The status rules should be evaluated for the correct repo. In this test case, it should correctly detect that `master`'s last build status was a failure for the given payload repo, and issue a success notification.
Configuration menu - View commit details
-
Copy full SHA for a3eea15 - Browse repository at this point
Copy the full SHA a3eea15View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff d983684f9baf73fa91c5ec0c5b83a9821f51dd5f...a3eea15e3cb380c78b951d2730fd4fb77c60d887