Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS handling on Client API #1321

Open
ignasi35 opened this issue Apr 9, 2021 · 0 comments
Open

TLS handling on Client API #1321

ignasi35 opened this issue Apr 9, 2021 · 0 comments

Comments

@ignasi35
Copy link
Contributor

ignasi35 commented Apr 9, 2021

When merging #1319 we may be able to use the grpc-java (netty client) API improvements to handle TLS certificates (in both trustmanagers and keymanagers) on the client API.

api: TlsChannelCredentials and TlsServerCredentials now support client certificates
and custom KeyManagers/TrustManagers. grpc-netty fully supports these options. grpc-okhttp
does not support keyfile-based configuration; you’d need to use a KeyManager. Most users
of Netty’s SslContext and GrpcSslContexts should be able to migrate and are encouraged to
do so, because this API does not have a Netty dependency and so is planned to become stable.

I'm not entirely sure what's the latest implementation but I think we had some coupling or class casting which we may be able to get rid of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant