Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: authlib 1.x (breaking changes) #3329

Open
stchris opened this issue Sep 20, 2023 · 1 comment
Open

FEATURE: authlib 1.x (breaking changes) #3329

stchris opened this issue Sep 20, 2023 · 1 comment
Labels
feature-request Requests for new features or enhancements of existing features Moderate Issue that may require attention
Milestone
3.15.2

Comments

@stchris
Copy link
Contributor

stchris commented Sep 20, 2023

Is your feature request related to a problem? Please describe.
The latest version of authlib (1.21.1) tested in 3.15.1-rc1 doesn't quite work with OAuth configured because of breaking changes in the API:

File "/aleph/aleph/views/sessions_api.py", line 101, in oauth_callback
    oauth.provider.framework.set_session_data(request, "state", state.get("state"))
AttributeError: 'FlaskIntegration' object has no attribute 'set_session_data'"

Describe the solution you'd like
Check all items from the changelog and this gist to make the latest version of authlib work.

Describe alternatives you've considered
For the moment the latest version of authlib is 0.15.5

Additional context
@stchris stchris added feature-request Requests for new features or enhancements of existing features triage These issues need to be reviewed by the Aleph team labels Sep 20, 2023
@stchris stchris added this to the 3.15.2 milestone Sep 20, 2023
@Rosencrantz Rosencrantz added Moderate Issue that may require attention and removed triage These issues need to be reviewed by the Aleph team labels Sep 26, 2023
@ksotik
Copy link
Contributor

ksotik commented May 3, 2024

Hi, it's still actual problem on 3.15.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request Requests for new features or enhancements of existing features Moderate Issue that may require attention
Projects
None yet
Milestone
3.15.2
Development

No branches or pull requests
3 participants
@stchris @Rosencrantz @ksotik