Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Introduce dedicated types for Any type aliases #2020

Closed
mattsse opened this issue Feb 6, 2025 · 2 comments · Fixed by #2046
Closed

[Feature] Introduce dedicated types for Any type aliases #2020

mattsse opened this issue Feb 6, 2025 · 2 comments · Fixed by #2046
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@mattsse
Copy link
Member

mattsse commented Feb 6, 2025

Component

rpc

Describe the feature you would like

currently we have type aliases for

/// A catch-all block type for handling blocks on multiple networks.
pub type AnyRpcBlock =
WithOtherFields<Block<WithOtherFields<Transaction<AnyTxEnvelope>>, AnyRpcHeader>>;
/// A catch-all transaction type for handling transactions on multiple networks.
pub type AnyRpcTransaction = WithOtherFields<Transaction<AnyTxEnvelope>>;

this prevents us from implementing additional functionality on those types

we can fix that by introducing new wrapper types for those aliases

TODO

  • introduce new wrapper structs for the Any aliases with deref+derefmut
  • implement required traits

ref #2019

Additional context

No response

@mattsse mattsse added enhancement New feature or request good first issue Good for newcomers labels Feb 6, 2025
@mattsse mattsse added this to Alloy Feb 6, 2025
@github-project-automation github-project-automation bot moved this to Todo in Alloy Feb 6, 2025
@temaniarpit27
Copy link

Can i pick this up?

@mattsse
Copy link
Member Author

mattsse commented Feb 7, 2025

assinged, ty

@mattsse mattsse moved this from Todo to In Progress in Alloy Feb 7, 2025
@yash-atreya yash-atreya added this to the v1.0 milestone Feb 28, 2025
@jenpaff jenpaff assigned yash-atreya and unassigned temaniarpit27 Mar 4, 2025
@jenpaff jenpaff modified the milestones: v1.0, v0.2 Mar 4, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Alloy Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants