We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
signers
ref #2027
these two traits are object-safe but there are usecases where we need the functionality of both
these traits are usually implemented for the same type:
alloy/crates/signer-local/src/lib.rs
Line 178 in ef23dae
Line 96 in ef23dae
I'd be nice to use dyn with both, which can be achieved via a helper trait
dyn
trait AnySinger<S>: Singer<S> + TxSigner<S> {} impl<T, S> AnySinger<Signer> for T where T: Signer<S> + TxSigner<S>
Sync
No response
The text was updated successfully, but these errors were encountered:
I's like to work on this.
Sorry, something went wrong.
assigned ty
@mattsse Should I implement both the traits in a new single file (maybe any_signer.rs) or do you want it to be seperate files?
any_signer.rs
we can simply add this in the file this resides in
alloy/crates/network/src/transaction/signer.rs
Line 81 in b618450
Signer
TxSigner
SignerSync
TxSignerSync
startup-dreamer
Successfully merging a pull request may close this issue.
Component
signers
Describe the feature you would like
ref #2027
these two traits are object-safe but there are usecases where we need the functionality of both
these traits are usually implemented for the same type:
alloy/crates/signer-local/src/lib.rs
Line 178 in ef23dae
alloy/crates/signer-local/src/lib.rs
Line 96 in ef23dae
I'd be nice to use
dyn
with both, which can be achieved via a helper traitTODO
Sync
Additional context
No response
The text was updated successfully, but these errors were encountered: