Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] layers don't work with fillers enabled #2112

Closed
yash-atreya opened this issue Feb 24, 2025 · 1 comment
Closed

[Bug] layers don't work with fillers enabled #2112

yash-atreya opened this issue Feb 24, 2025 · 1 comment
Labels
bug Something isn't working c-provider

Comments

@yash-atreya
Copy link
Member

Component

provider, pubsub

What version of Alloy are you on?

No response

Operating System

None

Describe the bug

If fillers such as RecommendedFillers are enabled in the provider along with custom .layer(..) implementations,

Overriden methods in the layer's provider impl are not called.

Repro: https://github.com/onbjerg/provider-builder-repro
@yash-atreya yash-atreya added bug Something isn't working c-provider investigate Able to reproduce, requires investigation labels Feb 24, 2025
@github-project-automation github-project-automation bot moved this to Todo in Alloy Feb 24, 2025
@yash-atreya yash-atreya added reproduce and removed investigate Able to reproduce, requires investigation reproduce labels Feb 24, 2025
@yash-atreya
Copy link
Member Author

Resolved by #2099

@github-project-automation github-project-automation bot moved this from Todo to Done in Alloy Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working c-provider
Projects
Alloy
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yash-atreya