Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add manual helper deserde for pending block #2139

Open
mattsse opened this issue Mar 4, 2025 · 0 comments
Open

[Feature] Add manual helper deserde for pending block #2139

mattsse opened this issue Mar 4, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@mattsse
Copy link
Member

mattsse commented Mar 4, 2025

Component

rpc

Describe the feature you would like

ref #2117

for some reasons client remove fields from the rpc response for pending block.

this is very inconvenient because we would need to
a) make those optional
b) use a different type for pending block

instead we can use manual deserde for the pending block and use default values when we deserialize the block

TODO

  • add manual helper deserde function for rpc Block and Header rpc types that use default values if those fields are missing

we only want this for the pending block so we need to check this when we send the getBlock request and deserialize accordingly

Additional context

No response

@mattsse mattsse added the enhancement New feature or request label Mar 4, 2025
@github-project-automation github-project-automation bot moved this to Todo in Alloy Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants