unreachable!

[malik672]

Component

providers

Describe the feature you would like

in the crate dir, under rpc-client/call.rs for error handling the code currently uses unreachable! when it encounters an incorrect state. won't it be better to use custom errors Instead of using unreachable! or maybe i'm missing something

Additional context

No response

[robinsdan]

because the state is checked in the poll function, it will never encounter an incorrect state error.

[malik672]

i know though, i'm talking about the error handling itself, won't it just be better to return a custom error to the caller in case the incorrect state ever get's invoked

[prestwich]

no, the unreachable!() is not handling (or failing to handle) an error, it's communicating to the compiler that the program is incorrect if that line is ever reached

[malik672]

oh, thanks