[Bug] Incorrect Deserialize for PubSubItem::Notification

[leruaa]

Component

json-rpc

What version of Alloy are you on?

v0.1.0 (latest main branch)

Operating System

Linux

Describe the bug

Looking at:

alloy/crates/json-rpc/src/notification.rs

Lines 55 to 72 in 0ba6b61

	"id" => {
	if id.is_some() {
	return Err(serde::de::Error::duplicate_field("id"));
	}
	id = Some(map.next_value()?);
	}
	"subscription" => {
	if subscription.is_some() {
	return Err(serde::de::Error::duplicate_field("subscription"));
	}
	subscription = Some(map.next_value()?);
	}
	"result" => {
	if result.is_some() {
	return Err(serde::de::Error::duplicate_field("result"));
	}
	result = Some(map.next_value()?);
	}

It seems PubSubItem try to deserialize an EthNotification from a json that looks like this:

{
  "jsonrpc": "2.0",
  "method": "eth_subscription",
  "subscription": "0x..."
  "result": {},
}

Whereas the correct json is like this:

{
  "jsonrpc": "2.0",
  "method": "eth_subscription",
  "params": {
    "subscription": "0x..."
    "result": {},
  }
}