Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imported CSS files were ignored #15

Open
ghost opened this issue May 17, 2011 · 4 comments
Open

Imported CSS files were ignored #15

ghost opened this issue May 17, 2011 · 4 comments

Comments

@ghost
Copy link

ghost commented May 17, 2011

Hi there,

I just tried out vogue and it just does not work. So I looked at the code of the current project I'm working on saw that there is one main CSS file which includes all neccessary css files by @import-statement. But when I change something in one of these imported css files, no change were made by vogue.

If I change the main css file, everything works fine.

Try it out: create a main css file and import another css by placing @import "another.css" into the main css. Then change something in another.css and you will see, no change in the browser.

Martin

@andrewdavey
Copy link
Owner

Vogue currently only finds stylesheets included using link elements. Whilst it's feasible to scan the stylesheets for imports, I'm unsure how to force the browser to reload stylesheets included that way. I suppose I could append a new link element for updated stylesheet...

I avoid using @import myself (http://www.stevesouders.com/blog/2009/04/09/dont-use-import/) so haven't hit this problem before.

I'm very happy to accept pull requests if someone would like to work on this issue.

@ghost
Copy link
Author

ghost commented May 18, 2011

I avoid using@import myself too, but in my current project another programmer did this. I just removed the import-statements and linked the stylesheets directly. Now it works correctly.

Maybe I will change this and do a pull request, if I find time for it ;)

@andrewdavey
Copy link
Owner

OK, I'm glad you were able to work around the problem. I'll leave this issue open in the hope that you, or some other kind soul, is able to submit a patch :)

@Munter
Copy link

Munter commented Dec 29, 2011

@import statements are sadly needed if you want to avoid IEs stylesheet limit. I hit that one all the time when I am doing css at work since we are using very modular code and stylesheets come from all over the place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants