Skip to content

Commit f8ca55d

Browse files
committed
doc(winerrors): mark better hidden WinErrors
Linux: all pass Windows: + PY2: errors=5 + PY3: errors=4 + CYGWIN-PY2: errors=7, failures=1 + CYGWIN-PY2: errors=6, failures=1
1 parent 96b8987 commit f8ca55d

File tree

2 files changed

+29
-6
lines changed

2 files changed

+29
-6
lines changed

git/test/test_docs.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,10 @@ def tearDown(self):
1919
gc.collect()
2020

2121
# @skipIf(HIDE_WINDOWS_KNOWN_ERRORS, ## ACTUALLY skipped by `git.submodule.base#L869`.
22-
# "FIXME: helper.wrapper fails with: PermissionError: [WinError 5] Access is denied: "
23-
# "'C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\test_work_tree_unsupportedryfa60di\\master_repo\\.git\\objects\\pack\\pack-bc9e0787aef9f69e1591ef38ea0a6f566ec66fe3.idx") # noqa E501
22+
# FIXME: helper.wrapper fails with:
23+
# File "C:\projects\gitpython\git\util.py", line 99, in onerror
24+
# func(path) # Will scream if still not possible to delete.PermissionError: [WinError 5] Access is denied: "
25+
# "'C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\test_work_tree_unsupportedryfa60di\\master_repo\\.git\\objects\\pack\\pack-bc9e0787aef9f69e1591ef38ea0a6f566ec66fe3.idx") # noqa E501
2426
@with_rw_directory
2527
def test_init_repo_object(self, rw_dir):
2628
# [1-test_init_repo_object]

git/test/test_submodule.py

Lines changed: 25 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -664,8 +664,15 @@ def test_add_empty_repo(self, rwdir):
664664
"""FIXME: ile "C:\projects\gitpython\git\cmd.py", line 671, in execute
665665
raise GitCommandError(command, status, stderr_value, stdout_value)
666666
GitCommandError: Cmd('git') failed due to: exit code(128)
667-
cmdline: git add 1__Xava verbXXten 1_test _myfile 1_test_other_file 1_XXava-----verbXXten
668-
stderr: 'fatal: pathspec '"1__çava verböten"' did not match any files'
667+
cmdline: git commit -m new file added
668+
stderr: '
669+
*** Please tell me who you are.
670+
Run
671+
git config --global user.email "[email protected]"
672+
git config --global user.name "Your Name"
673+
to set your account's default identity.
674+
Omit --global to set the identity only in this repository.
675+
fatal: unable to auto-detect email address (got 'appveyor@APPVYR-WIN.(none)')'
669676
""")
670677
@with_rw_directory
671678
def test_git_submodules_and_add_sm_with_new_commit(self, rwdir):
@@ -725,8 +732,22 @@ def test_git_submodules_and_add_sm_with_new_commit(self, rwdir):
725732
assert sm_too.binsha != sm.binsha
726733

727734
# @skipIf(HIDE_WINDOWS_KNOWN_ERRORS, ## ACTUALLY skipped by `git.submodule.base#L869`.
728-
# "FIXME: helper.wrapper fails with: PermissionError: [WinError 5] Access is denied: "
729-
# "'C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\test_work_tree_unsupportedryfa60di\\master_repo\\.git\\objects\\pack\\pack-bc9e0787aef9f69e1591ef38ea0a6f566ec66fe3.idx") # noqa E501
735+
# FIXME: helper.wrapper fails with:
736+
# File "C:\projects\gitpython\git\test\test_submodule.py", line 784, in test_git_submodule_compatibility
737+
# rsm = parent.submodule_update()
738+
# ...PY2
739+
# File "C:\projects\gitpython\git\util.py", line 99, in onerror
740+
# func(path) # Will scream if still not possible to delete.
741+
# WindowsError: [Error 5] Access is denied:
742+
# u'c:\\users\\appveyor\\appdata\\local\\temp\\1\\test_git_submodule_compatibilitymjhy3r\\parent\\
743+
# .git\\modules\\mymodules\\myname\\modules\\nested-submodule\\mine\\objects\\pack\\
744+
# pack-908988cf6b97e7eebb246e2d0429eb42c3888af4.idx'
745+
# ...PY3
746+
# File "C:\projects\gitpython\git\util.py", line 99, in onerror
747+
# func(path) # Will scream if still not possible to delete.
748+
# PermissionError: [WinError 5] Access is denied: 'C:\\Users\\appveyor\\AppData\\Local\\Temp
749+
# \\1\\test_git_submodule_compatibility293ite1l\\parent\\.git\\modules\\mymodules\\myname\\modules\\
750+
# nested-submodule\\mine\\objects\\pack\\pack-908988cf6b97e7eebb246e2d0429eb42c3888af4.idx'
730751
@with_rw_directory
731752
def test_git_submodule_compatibility(self, rwdir):
732753
parent = git.Repo.init(osp.join(rwdir, 'parent'))

0 commit comments

Comments
 (0)